Code split out web3 bundles #6623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kurtisassad
force-pushed
the
ka.bundlesizeFix
branch
3 times, most recently
from
d14fa01 to
993f459
Compare
|
@kurtisassad what's the bundle size these days for initial load, is it worse that what we had a year ago / better or worse |
kurtisassad
force-pushed
the
ka.bundlesizeFix
branch
from
993f459 to
81bcc05
Compare
|
@dillchen We are slowly slipping. Half a year ago we were at 4mb After this PR we will be at 5mb. Anyways the eng team have had long conversations about how we plan on fixing this in the future (Layout.tsx bloat). But as mentioned in the PR this will be a huge refactor on a legacy component, so there are no further easy wins here. What is interesting to note is that if we were to remove the layout entirely (not a feasible solution, but gives some sense into how much bloat it adds), we would be around 3mb: (This image is just a theoretical calculation, we can't achieve this currently) |
|
Any ticket / slack convo I can see that discusses this? Def of interest to
me but makes sense re no free lunch
Sent via Superhuman iOS ***@***.***>
…On Wed, Feb 7 2024 at 2:21 PM, Roger Torres ***@***.***> wrote:
***@***.**** approved this pull request.
LGTM
—
Reply to this email directly, view it on GitHub
<#6623 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABIWMHK2VMYLDS673RPSKOTYSPH2HAVCNFSM6AAAAABC6JWIX6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNRYGU4TMNBXGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Issue
Closes: #6624
Description of Changes
stats
Before:
After:
Other considerations
This should not be viewed as a complete solution. It is only a bandaid fix on the main problem which is the ease of adding bloat to Layout.tsx. We need to establish a frontend pattern so that we don't run into this issue again.
This bandaid fix is bad in practice because it reduces code readability, but will be necessary to cut out ~30% of our initial bundle size.